Inspect Block Page #378
Merged
Inspect Block Page #378
+325
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VanishMax
reviewed
Feb 24, 2025
VanishMax
approved these changes
Feb 26, 2025
src/shared/api/server/block/index.ts
Outdated
Comment on lines
60
to
61
| startAsset: startMetadata.toJson(), | ||
| endAsset: endMetadata.toJson(), |
There was a problem hiding this comment.
question: doesn't serialize() function apply here? Wandering why is it serialized by-hand here?
There was a problem hiding this comment.
Yes! Tbh, I wasn't aware of this piece of code, but I have replaced it and learned a few things along the way.
| </div> | ||
| <div className='grid grid-cols-4'> | ||
| <div className='grid grid-cols-subgrid col-span-4'> | ||
| <TableCell heading>From</TableCell> |
There was a problem hiding this comment.
question: how ok is the experience with this component after using it?
There was a problem hiding this comment.
I didn't try all the props, but it was a straight fwd drop-n-replace 👍
|
It works, merging 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #338